fix(funding): the manifest guard billed contributors for my public copy - #161
Merged
Merged
Conversation
`test_funding_manifest.py` pinned the benchmark case count in `funding.json` to `len(load_corpus())`. The next contributor pull request to add corpus cases, #145, went red on both platforms with `assert 54 == 57`, against a file the contributor had never touched and had no business editing. The guard worked. It was in the wrong place. A public claim of mine is not a contributor's problem to fix, and a red check on their branch for it is a tax they cannot pay. So the manifest no longer quotes counts at all, and this no longer checks them. What stays pinned is what moves on a release rather than on a contribution: the version and the licence, both of which change in a commit I make anyway. The counts live in the README, where `test_readme_claims.py` guards them and the change and the claim arrive in the same pull request. This is the same rule CONTRIBUTORS.md landed on yesterday, applied consistently this time: stamp a number with a date when it moves on its own, pin it only when the person changing it is the person who can fix it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
test_funding_manifest.py, added yesterday, pinned the benchmark case count infunding.jsontolen(load_corpus()).#145 adds three benign
corpus cases. It went red on both platforms:
funding.jsonis a funding manifest. The contributor had never touched it, hasno business editing it, and could not have anticipated it. The guard worked
exactly as designed and was in the wrong place.
The rule this settles
Pin a number when the person who changes it is the person who can fix it.
Stamp it with a date when it moves on its own.
CONTRIBUTORS.mdlanded on the same rule yesterday for commit counts, and thisapplies it consistently rather than having two policies a day apart.
Changes
The manifest no longer quotes counts. It says the benchmark runs at zero misses
and zero false positives, which is the meaningful claim, and points at the
README for current figures.
test_readme_claims.pyalready guards those, andthere the claim and the change arrive in the same pull request.
Adds
test_the_manifest_quotes_no_count_that_a_contribution_can_moveso thenext person who reaches for a nice big number in the manifest gets told why not.
Unblocks #145, which needs a re-run once this lands.
Checks
1,197 tests pass. Benchmark 0/0. Nothing frozen touched, fingerprint unchanged
at
15846a0915769d4a. Manifest still validates against the funding.json v1.1.0schema.